Skip to content

httplib fixes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2018
Merged

httplib fixes #24

merged 4 commits into from
Feb 23, 2018

Conversation

thehesiod
Copy link
Contributor

@thehesiod thehesiod commented Feb 23, 2018 •
edited
Loading

adds unpatching

@thehesiod thehesiod mentioned this pull request Feb 23, 2018
Merged
haotianw465
haotianw465 reviewed Feb 23, 2018
View reviewed changes
Copy link
Contributor

@haotianw465 haotianw465 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update CHANGELOG.rst about your unreleased changes, as well as updated API ref doc on util module since you added a new method unwrap?

@thehesiod
Copy link
Contributor Author

updated changelog, unsure about api doc ref as the other methods in the util module don't seem to be documented under docs/

@haotianw465
Copy link
Contributor

My bad. It is here https://github.com/aws/aws-xray-sdk-python/blob/master/docs/aws_xray_sdk.ext.rst but no need to update as it is not a new module.

@haotianw465 haotianw465 merged commit 3f30877 into aws:master Feb 23, 2018
@thehesiod thehesiod deleted the thehesiod-httplib-fixes branch February 23, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haotianw465 haotianw465 haotianw465 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thehesiod @haotianw465